Add method to clear header extensions#360
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 82.60% 82.64% +0.03%
==========================================
Files 28 28
Lines 3433 3440 +7
==========================================
+ Hits 2836 2843 +7
Misses 427 427
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adding a method to clear RTP header extensions. Also, modifying `DelExtension` to clear the extension flag if DelExtension will delete the last extension.
boks1971
force-pushed
the
raja_clear_extensions
branch
from
4bdd4e0 to
44cd517
Compare
boks1971
changed the title
JoTurk
approved these changes
May 1, 2026
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Thank you, I wonder what is your use case?
JoTurk
reviewed
May 1, 2026
| if len(h.Extensions) == 0 { | ||
| h.Extension = false | ||
| h.ExtensionProfile = 0 | ||
| } |
Member
There was a problem hiding this comment.
good catch, would be cool to include a unit test for Marshal to make sure we don't set the extension bit.
Contributor
Author
Exporting to some thing like gstreamer pipeline where the extensions are not useful. Just need the payload. |
boks1971
force-pushed
the
raja_clear_extensions
branch
from
fdcdb80 to
0b3423a
Compare
boks1971
force-pushed
the
raja_clear_extensions
branch
from
0b3423a to
f6ea08a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a method to clear RTP header extensions.
Also, modifying
DelExtensionto clear the extension flag if DelExtension will delete the last extension.